fix: keep fast-element exports explicit#7485
Closed
janechu wants to merge 2 commits intoreleases/fast-element-v3from
Closed
fix: keep fast-element exports explicit#7485janechu wants to merge 2 commits intoreleases/fast-element-v3from
janechu wants to merge 2 commits intoreleases/fast-element-v3from
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Abandoning this, context was lost due to a misunderstanding of barrel exports. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
binding.js/hydration.jsfast-elementsecondary entrypoints by makingindex.debug.ts,index.rollup.ts, andindex.rollup.debug.tsexplicitbinding/exports.ts/hydration/exports.tssource filesmetadata.jsandpending-task.jsout of the public export map🎫 Issues
👩💻 Reviewer Notes
declarative.tscontinues to own the hydratable-template side effect via the existing side-effect importinstall-element-hydration.jsandinstall-hydratable-view-templates.jsstay as dedicated side-effect entrypointsnpm run checkchangereports that no new change files are needed📑 Test Plan
npm run buildnpm run prebuild -w sites/websitenpm run biome:checknpm run checkchangenpx playwright test src/components/hydration.pw.spec.ts src/components/element-controller.pw.spec.ts --project=chromium✅ Checklist
General
$ npm run change